[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

[Paul Robinson via Phabricator via cfe-commits]

probinson added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:2155
+
+Emit debug info for types that are unused but defined by the program.
+
----------------
I think this description goes counter to how other options are described, which basically is about the positive form of the option.   If that's the case, this wants to be something more like "Suppress (or emit) debug info ..."


================
Comment at: clang/include/clang/Driver/Options.td:927
+defm eliminate_unused_debug_types : OptOutFFlag<"eliminate-unused-debug-types",
+  "Emit ", "Do not emit ", " debug info for defined but unused types">;
 def femit_all_decls : Flag<["-"], "femit-all-decls">, Group<f_Group>, Flags<[CC1Option]>,
----------------
The positive form of the option suppresses info, so "Emit " and "Do not emit " are reversed here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80242/new/

https://reviews.llvm.org/D80242