[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

[Michael Spencer via Phabricator via cfe-commits]

Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.

lgtm with the fix I mentioned.



================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3629
 #undef MERGE_ASSIGN_VALUE
+  llvm::sys::Process::UseANSIEscapeCodes(DiagnosticOpts->UseANSIEscapeCodes);
   return true;
----------------
This should probably be moved out so that this function only parses args and doesn't modify outside state.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82874/new/

https://reviews.llvm.org/D82874