[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 10:50:31 PDT 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM with comment addressed.



================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:325
+  if ((FPU & SveMode) && HasMatmulInt8)
+    Builder.defineMacro("__ARM_FEATURE_SVE_MATMUL_INT8", "1");
+
----------------
It seems `HasMatmulInt8` is the same as `HasMatMul`, please reuse that instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82623/new/

https://reviews.llvm.org/D82623





More information about the cfe-commits mailing list