[PATCH] D82891: [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 10:50:20 PDT 2020


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

FileIndex was built out of threadsafe components, so update() didn't have data
races, but wasn't actually correct.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82891

Files:
  clang-tools-extra/clangd/index/FileIndex.cpp
  clang-tools-extra/clangd/index/FileIndex.h
  clang-tools-extra/clangd/index/Symbol.h
  clang-tools-extra/clangd/unittests/FileIndexTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82891.274532.patch
Type: text/x-patch
Size: 6820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200630/e9ec9d35/attachment.bin>


More information about the cfe-commits mailing list