[PATCH] D82388: move "basic" builtins to TableGen

Nathan Froyd via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 10:18:15 PDT 2020


froydnj updated this revision to Diff 274526.
froydnj edited the summary of this revision.
froydnj removed a reviewer: stoklund.
froydnj added a comment.
Herald added a subscriber: mgrang.

Thanks for the pointer @craig.topper !  I've updated the patch to use `LessRecordByID`.  I've also made some small changes to how the code selects the correct macro to output and done a better job converting the builtins by using an automated script, available at https://gist.github.com/froydnj/1192911af46661fb62e724957099d4e8 .  I did have to touch up the comments a bit, but the more-automated conversion pointed out several errors that my attempt to use the preprocessor had run into.

Removing Jakob since there are no more TableGen changes needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82388/new/

https://reviews.llvm.org/D82388

Files:
  clang/include/clang/AST/Expr.h
  clang/include/clang/Basic/BuiltinTableGenDefs.inc
  clang/include/clang/Basic/Builtins.def
  clang/include/clang/Basic/Builtins.h
  clang/include/clang/Basic/Builtins.td
  clang/include/clang/Basic/BuiltinsAArch64.def
  clang/include/clang/Basic/BuiltinsAMDGPU.def
  clang/include/clang/Basic/BuiltinsARM.def
  clang/include/clang/Basic/BuiltinsBPF.def
  clang/include/clang/Basic/BuiltinsHexagon.def
  clang/include/clang/Basic/BuiltinsLe64.def
  clang/include/clang/Basic/BuiltinsMips.def
  clang/include/clang/Basic/BuiltinsNEON.def
  clang/include/clang/Basic/BuiltinsNVPTX.def
  clang/include/clang/Basic/BuiltinsPPC.def
  clang/include/clang/Basic/BuiltinsSVE.def
  clang/include/clang/Basic/BuiltinsSystemZ.def
  clang/include/clang/Basic/BuiltinsWebAssembly.def
  clang/include/clang/Basic/BuiltinsX86.def
  clang/include/clang/Basic/BuiltinsX86_64.def
  clang/include/clang/Basic/BuiltinsXCore.def
  clang/include/clang/Basic/CMakeLists.txt
  clang/include/clang/Basic/arm_neon_incl.td
  clang/include/clang/module.modulemap
  clang/lib/AST/StmtPrinter.cpp
  clang/lib/Basic/Builtins.cpp
  clang/lib/Sema/OpenCLBuiltins.td
  clang/lib/Sema/SemaChecking.cpp
  clang/lib/Sema/SemaExpr.cpp
  clang/test/Analysis/bstring.c
  clang/utils/TableGen/CMakeLists.txt
  clang/utils/TableGen/ClangBuiltinsEmitter.cpp
  clang/utils/TableGen/MveEmitter.cpp
  clang/utils/TableGen/NeonEmitter.cpp
  clang/utils/TableGen/SveEmitter.cpp
  clang/utils/TableGen/TableGen.cpp
  clang/utils/TableGen/TableGenBackends.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82388.274526.patch
Type: text/x-patch
Size: 179586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200630/9fcc40bc/attachment-0001.bin>


More information about the cfe-commits mailing list