[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 30 09:12:16 PDT 2020
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, thank you!
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6278
+ return true;
+ // FIXME(liuhui): Ideally, we should check the ctor parameter list to
+ // verify whether it is a copy ctor or a move ctor.
----------------
comment: default, copy, and move constructor?
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6285
+ auto Op = Id.OperatorFunctionId.Operator;
+ if (Op == OverloadedOperatorKind::OO_Equal)
+ return true;
----------------
Maybe a comment like "copy and move assignment"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82548/new/
https://reviews.llvm.org/D82548
More information about the cfe-commits
mailing list