[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 00:30:13 PDT 2020


hokein marked an inline comment as done.
hokein added a comment.

In D82771#2120214 <https://reviews.llvm.org/D82771#2120214>, @klimek wrote:

> In what situation are we calling child matchers repeatedly with the same matcher on the same node?


I guess a pattern like https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp#L29-L40?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82771/new/

https://reviews.llvm.org/D82771





More information about the cfe-commits mailing list