[PATCH] D82562: Implement AVX ABI Warning/error

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 29 18:34:41 PDT 2020


craig.topper added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:2497
+                                 bool IsArgument) {
+  if (!CallerMap.lookup(Feature) && !CalleeMap.lookup(Feature))
+    return Diag.Report(CallLoc, diag::warn_avx_calling_convention)
----------------
Should we save the lookup results in bool so we only do 2 lookups instead of 4 in the common case where there is no error/warning


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82562/new/

https://reviews.llvm.org/D82562





More information about the cfe-commits mailing list