[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

[Chi Chun Chen via Phabricator via cfe-commits]

cchen marked 3 inline comments as done.
cchen added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7893-7897
+        llvm::errs() << "DEBUG in CGOpenMPRuntime.cpp\n";
+        OASE->getLowerBound()->dump();
+        OASE->getLength()->dump();
+        OASE->getStride()->dump();
+
----------------
ABataev wrote:
> Must be removed
I'll remove the commit. Thanks


================
Comment at: clang/lib/Sema/SemaExpr.cpp:4907
+  if (Stride) {
+    auto Res =
+        PerformOpenMPImplicitIntegerConversion(Stride->getExprLoc(), Stride);
----------------
ABataev wrote:
> `auto`->`ExprResult`
Should I also change it for LowerBound and Length? Just to make it consistent.


================
Comment at: clang/test/OpenMP/target_update_ast_print.cpp:66
 
+#pragma omp target update from(marr [1:1:1] [0:2:] [1:0])
+
----------------
ABataev wrote:
> It would be good to add some positive tests for other constructs, like `target`, `target data` etc., if allowed.
I'm going to add those, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82800/new/

https://reviews.llvm.org/D82800