[PATCH] D82729: [clangd] Make sure headers are available in FS inside FindSymbolsTests
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 29 11:21:39 PDT 2020
sammccall added a comment.
Why? workspaceSymbols depends on the index only.
ISTM the dynamic index + blockUntilIdle should be enough - what does the FS have to do with it?
Oh, is this a race condition due to async preamble builds?
---
I think a slightly more principled fix here is that we should just use TestTU + clangd::getWorkspaceSymbols directly and stop using ClangdServer.
We can land this as-is if tests are flaking and need a quick fix and TestTU is too invasive, but it seems it shouldn't be complicated. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82729/new/
https://reviews.llvm.org/D82729
More information about the cfe-commits
mailing list