[PATCH] D82793: [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension point

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 29 11:21:32 PDT 2020


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls.
Herald added a project: clang.

By making all overloads non-virtual and delegating to a differently-named
private method, we avoid any (harmless) name-hiding in the subclasses.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82793

Files:
  clang-tools-extra/clangd/Preamble.cpp
  clang-tools-extra/clangd/support/ThreadsafeFS.cpp
  clang-tools-extra/clangd/support/ThreadsafeFS.h
  clang-tools-extra/clangd/unittests/ClangdTests.cpp
  clang-tools-extra/clangd/unittests/TestFS.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82793.274181.patch
Type: text/x-patch
Size: 4223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200629/bd4c5750/attachment-0001.bin>


More information about the cfe-commits mailing list