[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

[Nathan James via Phabricator via cfe-commits]

njames93 marked an inline comment as done.
njames93 added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27
+   ``::std::basic_string`` and ``::std::basic_string_view`` are considered. 
+   The list of methods to consired is fixed.
 
----------------
aaron.ballman wrote:
> I'm not certain how to read that last sentence (I read it as: the list of methods is considered fixed and cannot be extended, which seems like a bad interpretation). Maybe it's talking about fix-its instead?
> 
> Regardless, the typo consired -> consider should be fixed.
That typo was here before I got here, but I think it means `The list of methods inside the classes to consider are fixed`. In other words you can't make the check detect calls to `::MyStringClass::MyFind()`.

Does `The list of methods inside the classes to consider are fixed.` sound like a good replacement for the it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82720/new/

https://reviews.llvm.org/D82720