[PATCH] D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj"

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 29 06:59:17 PDT 2020


erichkeane accepted this revision.
erichkeane added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/Tooling/CMakeLists.txt:10
 if (MSVC)
+  set_source_files_properties(RecursiveASTVisitorTests/Callbacks.cpp PROPERTIES COMPILE_FLAGS /bigobj)
   set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj)
----------------
Just a nit, but I think we want to alphabetically order these like include files (so after the ExprVisitor below).  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82766/new/

https://reviews.llvm.org/D82766





More information about the cfe-commits mailing list