[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 29 06:59:06 PDT 2020
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
A bunch of clang-format, plus 1 odd looking equation, otherwise this like good.
================
Comment at: llvm/lib/Support/X86TargetParser.cpp:27
+class FeatureBitset {
+ static constexpr unsigned NUM_FEATURE_WORDS = X86::CPU_FEATURE_MAX + 31 / 32;
+
----------------
Why is this CPU_FEATURE_MAX + 0? Are you missing parens?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82731/new/
https://reviews.llvm.org/D82731
More information about the cfe-commits
mailing list