[PATCH] D82157: Fix crash on `user defined literals`

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 29 01:02:21 PDT 2020


gribozavr2 added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:632
+    // As a node is built by folding tokens we cannot generate one
+    // for `_w`
+    Builder.markChildToken(S->getBeginLoc(), syntax::NodeRole::LiteralToken);
----------------
This comment makes sense, but it is not clear how it is connected to the implementation. Could you clarify? Also, could you re-wrap the comment to 80 columns? Where exactly in the AST do we have the source location that points to `_w`? What are we doing to avoid using that source location?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82157/new/

https://reviews.llvm.org/D82157





More information about the cfe-commits mailing list