[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 26 15:10:49 PDT 2020
dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
> Plus replacing a few std::map<string,...> with llvm::StringMap
That doesn't sound NFC since it changes ordering semantics. It seems to me like it should be done separately from the rest of the patch.
It would be nice to split up the rest of the patch too; besides simplifying review, if you leave the `#include` removals for a final commit it'll be easier to revert if/where necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82661/new/
https://reviews.llvm.org/D82661
More information about the cfe-commits
mailing list