[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 26 12:36:00 PDT 2020
sammccall added a comment.
> indicating how I would disentangle that code if I owned it. Hopefully that comment clarifies my position somewhat.
So your position on how to best write that code is interesting (I disagree, but I think there are probably types of projects where your priorities are the right ones. Maybe clang itself is one of them!)
But what would be really useful is to clarify your position on whether the warning in clang is delivering value. E.g. that you do want it enabled for clang, so we should rather turn this off at the clangd level.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82617/new/
https://reviews.llvm.org/D82617
More information about the cfe-commits
mailing list