[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 26 11:30:27 PDT 2020


aprantl added inline comments.


================
Comment at: clang/test/DebugInfo/debugify-each-original.c:57
+// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS
+// CHECK-NEXT: Simplify the CFG: PASS
----------------
We probably shouldn't check the effects of LLVM passes in the Clang test suite. When someone breaks one of those LLVM passes and that shouldn't cause an error in the Clang *frontend* test suite. It's sufficient to check that the pass is passed on to LLVM here. The operation of it should be checked either in LLVM or in an end-to-end test, e.g., inside debug-info-tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82547/new/

https://reviews.llvm.org/D82547





More information about the cfe-commits mailing list