[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 26 11:29:49 PDT 2020
sammccall added a comment.
Oops, I misread and forgot one point. The public interface can't (only) take `optional<StringRef>` because that's not implicitly convertible from a std::string which is what we usually want to pass. Thus the silly overloads, which we were going to fix with a more careful overload set approximating optional<StringRef> once we hit a case where we didn't know statically whether we had a working directory or not.
(Didn't push for it to be in this patch because getting overload sets right is hard)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81920/new/
https://reviews.llvm.org/D81920
More information about the cfe-commits
mailing list