[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 26 08:10:32 PDT 2020


gribozavr2 marked an inline comment as done.
gribozavr2 added inline comments.


================
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:646
+     * receives a DataRecursionQueue, can't call WalkUpFrom after traversing   \
+     * children because it only enqueues the children. and does not traverse   \
+     * them. TraverseStmt traverses the enqueued children, and we call         \
----------------
ymandel wrote:
> delete stray period after "children"
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82486/new/

https://reviews.llvm.org/D82486





More information about the cfe-commits mailing list