[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

Fri Jun 26 07:37:25 PDT 2020

dfukalov planned changes to this revision.
dfukalov added a comment.

In D82650#2116849 <https://reviews.llvm.org/D82650#2116849>, @yaxunl wrote:

> I think the point of -ffp-contract=fast is that it allows emitting fma across statements if there are such opportunities whereas -ffp-contract=on only allows fma in one statement
>
> https://llvm.org/docs/CompileCudaWithLLVM.html#flags-that-control-numerical-code

Yes, you're right. I was confused by current FE behavior and a number of different commits, reverts and re-commits.

Currently FE checks `allowFPContractWithinStatement()` and it returns false for FAST mode. As I understand, FAST mode should be more aggressive and include this case.
I'll re-work the change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82650/new/

https://reviews.llvm.org/D82650