[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 25 15:51:10 PDT 2020


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

> We could just kill all subexpr at the end of the full expression

I suspect that it would be pretty bad if you, say, kill the condition of the `if`-statement before picking the branch. Or kill the initializer in the `DeclStmt` before putting it into the variable (same for `CXXCtorInitializer` which isn't even a `Stmt`!).

> I might need a tip on how to test on ObjC code :)

Unfortunately i don't have any helpful tips for you :( Such code is not cross-compiled very often. I vaguely remember seeing some Objective-C code in linux software but it's most likely not very modern/representative. So i guess it's on us to inform you of the potential problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82598/new/

https://reviews.llvm.org/D82598





More information about the cfe-commits mailing list