[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check
Lewis Baker via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 25 10:46:41 PDT 2020
lewissbaker accepted this revision.
lewissbaker added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/Sema/SemaCoroutine.cpp:621
+ // returns a handle. In that case, even __builtin_coro_resume is not
+ // declared as noexcept, we claim that logically it does not throw.
+ if (FD->getBuiltinID() == Builtin::BI__builtin_coro_resume)
----------------
... it does not throw _into_ the coroutine that just suspended, but rather throws back out from whoever called coroutine_handle::resume().
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82415/new/
https://reviews.llvm.org/D82415
More information about the cfe-commits
mailing list