[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

[Bevin Hansson via Phabricator via cfe-commits]

ebevhan added a comment.

The last patchset contains the comment about rounding, so I think I will consider this accepted.

As a final addendum to the discussion on rounding and overflow... The last Appendix to the E-C TR does actually say:

  2.   In the first edition requires that overflow handling is done before rounding; for the second edition the order is changed: rounding should be done first, followed by overflow handling. Note that this change does not affect any result when the overflow mode is saturation. 

The wording in the main text could be a bit clearer about it being explicit, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73186/new/

https://reviews.llvm.org/D73186