[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

[Bjorn Pettersson via Phabricator via cfe-commits]

bjope added a comment.

I think the warnings can be hidden by something like this (I'm no expert in this area though, but it seems like this technique has been used a number of times before in llvm, so hopefully it applies here as well):

  diff --git a/clang-tools-extra/clangd/Preamble.cpp b/clang-tools-extra/clangd/Preamble.cpp
  index ca0a76db78f4..1970541bc56a 100644
  --- a/clang-tools-extra/clangd/Preamble.cpp
  +++ b/clang-tools-extra/clangd/Preamble.cpp
  @@ -230,6 +230,7 @@ llvm::Expected<ScannedPreamble>
   scanPreamble(llvm::StringRef Contents, const tooling::CompileCommand &Cmd) {
     class EmptyFS : public ThreadsafeFS {
     public:
  +    using ThreadsafeFS::view;
       llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
       view(llvm::NoneType) const override {
         return new llvm::vfs::InMemoryFileSystem;
  diff --git a/clang-tools-extra/clangd/support/ThreadsafeFS.h b/clang-tools-extra/clangd/support/ThreadsafeFS.h
  index aa6825fb3999..eb9016bad201 100644
  --- a/clang-tools-extra/clangd/support/ThreadsafeFS.h
  +++ b/clang-tools-extra/clangd/support/ThreadsafeFS.h
  @@ -42,6 +42,7 @@ public:
   
   class RealThreadsafeFS : public ThreadsafeFS {
   public:
  +  using ThreadsafeFS::view;
     llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
         view(llvm::NoneType) const override;
   };

at least I get no warnings when building clangd (haven't checked the unittests, but I don't care about warnings in those right now).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81920/new/

https://reviews.llvm.org/D81920