[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 25 02:08:42 PDT 2020
kadircet added inline comments.
================
Comment at: clang/include/clang/Basic/SourceManager.h:1649
const SrcMgr::SLocEntry &getLocalSLocEntry(unsigned Index,
bool *Invalid = nullptr) const {
assert(Index < LocalSLocEntryTable.size() && "Invalid index");
----------------
i think we should drop Invalid from the signature completely if we are going for this.
I've sent out D82532 to get rid of the libclang dependency on this, after it lands this should be possible to clear.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82498/new/
https://reviews.llvm.org/D82498
More information about the cfe-commits
mailing list