[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 24 20:05:53 PDT 2020
NoQ added a comment.
Mmm, well, on second thought, no, that probably won't be sufficient. As long as we're willing to warn on containers about which we know //absolutely nothing//, we'll still have some of those false positives. And if we stop warning on such containers, the check will probably become much more quiet and much less useful. So i think this check will work best as an opt-in style/lint guideline. It might still make a bit more sense with path-sensitive analysis but we'll still have to accept the inevitable obvious false positives so it's probably not worth it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71607/new/
https://reviews.llvm.org/D71607
More information about the cfe-commits
mailing list