[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

[Valeriy Dmitriev via Phabricator via cfe-commits]

vdmitrie added inline comments.


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:197
   }
   return DKind < OMPD_unknown ? static_cast<OpenMPDirectiveKind>(DKind)
                               : OMPD_unknown;
----------------
Should this be a comparison against llvm::omp::Directive_enumSize rather than OMPD_unknown?


And there is an assertion in file clang/lib/Basic/OpenMPKinds.cpp
that I guess needs to be updated the same way:
void clang::getOpenMPCaptureRegions(
    SmallVectorImpl<OpenMPDirectiveKind> &CaptureRegions,
    OpenMPDirectiveKind DKind) {
  assert(DKind <= OMPD_unknown);



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81736/new/

https://reviews.llvm.org/D81736