[PATCH] D82352: [clangd] Make background index thread count calculation clearer
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 24 15:47:22 PDT 2020
sammccall marked an inline comment as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/index/Background.h:140
+ // In production an explicit value is passed.
+ size_t ThreadPoolSize = 4,
std::function<void(BackgroundQueue::Stats)> OnProgress = nullptr);
----------------
kadircet wrote:
> maybe `ClangdServer::optsForTest().AsyncThreadsCount` instead of hardcoding 4 in another place ?
This file doesn't/shouldn't depend on clangdserver though :-(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82352/new/
https://reviews.llvm.org/D82352
More information about the cfe-commits
mailing list