[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 14:07:53 PDT 2020


rjmccall added a comment.

In D81869#2112440 <https://reviews.llvm.org/D81869#2112440>, @mibintc wrote:

> I decided that I shouldn't make float options that define a macro, like -ffast-math, as BENIGN_LANGOPT, I made ffp-contract= , fp-exception-behavior and rounding-mode BENIGN


That seems right to me.  @yaxunl, is this going to be okay with you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81869/new/

https://reviews.llvm.org/D81869





More information about the cfe-commits mailing list