[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

Xun Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 09:10:01 PDT 2020


lxfind marked an inline comment as done.
lxfind added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1286
+        continue;
+      if (CastInst) {
+        // If we have multiple cast instructions for the alloca, don't
----------------
junparser wrote:
> It is possible to handle multiple cast instructions as long as they are only used by lifetime marker intrinsic. 
It's certainly possible. I didn't do it here because a reasonable compiler frontend should never emit multiple cast instructions for the same variable in order to mark lifetime. If there are, they must be used for something else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82314/new/

https://reviews.llvm.org/D82314





More information about the cfe-commits mailing list