[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 09:10:00 PDT 2020


MyDeveloperDay added a comment.

I confirm this is still an issue as of v11 (trunk) and it looks like D21279: [clang-format] Fix some issues in clang-format's AlignConsecutive modes <https://reviews.llvm.org/D21279> was landed even though its not closed. (the code behind D21279 <https://reviews.llvm.org/D21279> has been changed probably since it was committed, but the tests appear to be inplace for that issue)

I don't see any LLVM contributions from the original author @KP for some time, @ambroyz are you pinging this issue because your keen for someone to look at it?

I think the tests will be of value, but I have a horrible feeling the code has moved on and this may not work without a rework, as the comments are not marked done it hard to understand where we are at.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D27651/new/

https://reviews.llvm.org/D27651





More information about the cfe-commits mailing list