[PATCH] D82326: [clangd] Disable printing of Value for tag-types on hover
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 24 08:04:23 PDT 2020
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:345
+ if (E->isValueDependent() || !E->EvaluateAsRValue(Constant, Ctx) ||
+ // Disable printing for tag-types, as they are usually confusing and might
+ // make clang crash while printing the expressions.
----------------
nit: tag -> record (not handling enums)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82326/new/
https://reviews.llvm.org/D82326
More information about the cfe-commits
mailing list