[PATCH] D82446: [clang] Fix duplicate warning

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 05:22:35 PDT 2020


aaron.ballman added inline comments.


================
Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273
   ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier);
-  DS.Finish(Actions, Actions.getASTContext().getPrintingPolicy());
   return false;
----------------
This change is incorrect -- `Finish` is what ensures the `DeclSpec` is in a consistent state (even in the presence of errors), so removing it would be bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82446/new/

https://reviews.llvm.org/D82446





More information about the cfe-commits mailing list