[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 03:12:36 PDT 2020


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

This may not be the right long-term solution, but the current behavior is pretty broken and this is cheap.



================
Comment at: clang/unittests/Format/FormatTest.cpp:6287
+  Style.BreakBeforeTernaryOperators = false;
+  verifyFormat("int x = aaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaa :\n"
+               "    bbbb                ? cccccccccccccccccc :\n"
----------------
aligning the question marks here is a bit weird (given DontAlign) but that's another patch.

If we disable the question-column behavior with dontalign, this patch will be completely dead, right?
May want to add a FIXME to remove in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82199/new/

https://reviews.llvm.org/D82199





More information about the cfe-commits mailing list