[PATCH] D82213: [Remarks] Add callsite locations to inline remarks
Florian Hahn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 24 02:40:14 PDT 2020
fhahn added a comment.
That's interesting. We are also using something similar for the matrix lowering remarks [1]: we traverse the inlining chain bottom up and emit a remark at each step which contains the expression available at that level. I think those approaches could be useful in general to surface remarks at the right level and it might be worth moving them somewhere so they can be shared. What do you think?
[1] https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp#L1783
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82213/new/
https://reviews.llvm.org/D82213
More information about the cfe-commits
mailing list