[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 24 00:29:56 PDT 2020
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2430
+ if (BaseType->containsErrors()) {
+ // FIXME: should we emit a diagnostic here? We already emit a diagnostic
+ // when parsing the error type.
----------------
I think this is fine, just "// already emitted this error" or so
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82086/new/
https://reviews.llvm.org/D82086
More information about the cfe-commits
mailing list