[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

thanks for the info @uabelho!

this looks like a dormant warning though, as StringRef is not implicitly convertible to NoneType (and vice-versa) hence anyone trying to make use of the hidden overload would get a hard compile error anyways.
Moreover this class is mostly accessed through a base pointer, hence name hiding in derived classes isn't really an issue (for most of the production code).

Also the warning itself seems to be noisy https://gcc.gnu.org/bugzilla/show_bug.cgi?id=20423. Interesting this seems to be only enabled for clang and nothing else, I wonder how it is decided.
Unfortunately history doesn't tell much https://github.com/llvm/llvm-project/blame/master/clang/CMakeLists.txt#L396.

There are 5 derived classes (3 of them are in tests), so just putting a using declaration to un-hide the overload seems too disruptive.
Again renaming the endpoints (and possibly changing the signature) just to suppress this warning also doesn't seem so nice.

I would rather like to turn-off this warning for at least gcc, assuming this is not specific to that version. Can you check if you see the warning with different versions of gcc?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81920/new/

https://reviews.llvm.org/D81920