[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

[Mikhail Goncharov via Phabricator via cfe-commits]

goncharov added a comment.

In D81408#2105188 <https://reviews.llvm.org/D81408#2105188>, @atrosinenko wrote:

> @goncharov
>
> Meanwhile, looking at the latest Buildkite build <https://buildkite.com/llvm-project/premerge-checks/builds/898> for this review, we have:
>
> name=artifacts/CMakeCache.txt (Linux)
>   ...
>   LLVM_ENABLE_PROJECTS:STRING=clang;compiler-rt;llvm
>   ...
>
>
> and
>
> name=artifacts/CMakeCache.txt (Windows)
>   ...
>   LLVM_ENABLE_PROJECTS:STRING=clang;llvm
>   ...
>
>
> So, isn't Windows build here just wasting CPU time?


@atrosinenko: could you please clarify what exactly is wrong? Windows not building 'compiler-rt'?

> Another my concern here is that the build plan pre-merge checks (buildkite) <https://reviews.llvm.org/harbormaster/plan/5/> is expressed with just a single "Make HTTP request" step with "When Complete: Wait For Message" (unlike the pre-merge checks <https://reviews.llvm.org/harbormaster/plan/4/> used for the initial upload). So, this build <https://reviews.llvm.org/harbormaster/build/73646/> failed like this (see the message tab):
> 
>   216557	merge_guards_bot	fail	Consumed	Thu, Jun 18, 16:13
>   216556	merge_guards_bot	working		Thu, Jun 18, 16:13
>   216538	merge_guards_bot	working		Thu, Jun 18, 15:51
> 
> 
> In D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list <https://reviews.llvm.org/D81282>, on the other hand, there is seemingly passed build <https://reviews.llvm.org/harbormaster/build/73581/>. Its messages are
> 
>   216370	merge_guards_bot	fail		Thu, Jun 18, 13:28
>   216365	merge_guards_bot	working		Thu, Jun 18, 13:25
>   216343	merge_guards_bot	pass	Consumed	Thu, Jun 18, 12:53
>   216342	merge_guards_bot	working		Thu, Jun 18, 12:52
> 
> 
> 
> 
>   So, it looks like now the `compiler-rt`-only pre-merge check cannot pass at all, but can be **marked** Passed **on re-upload only** based on what builder (Linux or Windows) will send its reply first.

Yes, there is a single request to buildkite and a single response that happens at "report" step after both windows and linux build are done, e.g. https://buildkite.com/llvm-project/premerge-checks/builds/898#7efe45eb-ac96-40aa-ba91-494a5812ec88

The latter "successfull" build was a temporary misconfiguration of the build scripts. 1. I believe I have restarted all affected builds but clearly missed some. 2. I have created https://github.com/google/llvm-premerge-checks/issues/206 to prevent this from happening,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81408/new/

https://reviews.llvm.org/D81408