[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

Mon Jun 22 12:21:59 PDT 2020

clementval added a comment.

In D81736#2107202 <https://reviews.llvm.org/D81736#2107202>, @jdenny wrote:

> My cmake skills are lacking.  Why are there are so many new DEPENDS relationships where there were none before?  Is it because omp_gen is generating a header file that's included (indirectly) in all those places, where apparently that sort of dependency was unusual?
>
> Have you tried building from a new, empty build directory on your local system?  Can you reproduce the CI fails without this fixup?

Yeah they are needed because of the indirect inclusion of the generated file. I could reproduce the failure from an empty build directory. This leads to the addition of the different depends in cmake files.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81736/new/

https://reviews.llvm.org/D81736