[PATCH] D82281: [clang-tidy] llvm-twine-local ignores parameters
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 22 10:45:51 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9a8b04114480: [clang-tidy] llvm-twine-local ignores parameters (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82281/new/
https://reviews.llvm.org/D82281
Files:
clang-tools-extra/clang-tidy/llvm/TwineLocalCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/llvm-twine-local.cpp
Index: clang-tools-extra/test/clang-tidy/checkers/llvm-twine-local.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/checkers/llvm-twine-local.cpp
+++ clang-tools-extra/test/clang-tidy/checkers/llvm-twine-local.cpp
@@ -13,6 +13,7 @@
using namespace llvm;
void foo(const Twine &x);
+void bar(Twine x);
static Twine Moo = Twine("bark") + "bah";
// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: twine variables are prone to use-after-free bugs
Index: clang-tools-extra/clang-tidy/llvm/TwineLocalCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/llvm/TwineLocalCheck.cpp
+++ clang-tools-extra/clang-tidy/llvm/TwineLocalCheck.cpp
@@ -19,8 +19,10 @@
void TwineLocalCheck::registerMatchers(MatchFinder *Finder) {
auto TwineType =
- qualType(hasDeclaration(recordDecl(hasName("::llvm::Twine"))));
- Finder->addMatcher(varDecl(hasType(TwineType)).bind("variable"), this);
+ qualType(hasDeclaration(cxxRecordDecl(hasName("::llvm::Twine"))));
+ Finder->addMatcher(
+ varDecl(unless(parmVarDecl()), hasType(TwineType)).bind("variable"),
+ this);
}
void TwineLocalCheck::check(const MatchFinder::MatchResult &Result) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82281.272494.patch
Type: text/x-patch
Size: 1263 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200622/90119faf/attachment-0001.bin>
More information about the cfe-commits
mailing list