[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

The test needs work (check/check-not lines+ filecheck), otherwise I think this should be alright, particularly if no one else has commented in a while.  I'd like to have you upload an updated test validating what you think should be happening before approving though.



================
Comment at: clang/test/CodeGen/xcore-unused-inline.c:4
+
+inline void dead_function(void) {}
----------------
What is this test validating? It should likely have a check line of some sort.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77068/new/

https://reviews.llvm.org/D77068