[PATCH] D82259: Deprecate error prone temporary directory APIs

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In D82259#2106279 <https://reviews.llvm.org/D82259#2106279>, @davezarzycki wrote:

> Sure, we can honor XDG_CACHE_DIR. Maybe as a followup, somebody can wire up Darwin's cache directory (which is retrievable via a BSD specific `confstr()` API with `_CS_DARWIN_USER_CACHE_DIR`). I'm not sure about other platforms.
>
> I'll wait for more feedback before updating the patch.


`llvm::sys::path::cache_directory` exists, it doesn't do anything special on Darwin (though would be the right place), but it does handle windows.

I'm not sure what the original motivation for `org.llvm.clang.$USER` format was, but it doesn't seem to be worth carrying over vs $CONFIG/clang/ to me - clang is well-known enough to "own" the name and most tools don't seem to add reverse-domains to these paths.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82259/new/

https://reviews.llvm.org/D82259