[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

JunMa via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 22 05:52:40 PDT 2020


junparser added a comment.

In D82029#2100675 <https://reviews.llvm.org/D82029#2100675>, @modocache wrote:

> Excellent, thank you! The test failures on the diff appear to be legitimate, they reproduce for me when I apply this patch to my local checkout and run `ninja check-clang`. Could you take a look?
>
> This LGTM otherwise! Also adding @junparser in case they have any thoughts, if not I'll accept after the test failures are addressed, Thanks!


@modocache LGTM, @lxfind Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82029/new/

https://reviews.llvm.org/D82029





More information about the cfe-commits mailing list