[PATCH] D82162: [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:570
+
+// We don't want a warning here as the call to this in Foo is in a scratch
+// buffer so its fix-it wouldn't be applied, resulting in invalid code.
----------------
I may be misunderstanding the comment here. I can understand not wanting to generate fixits into the scratch buffer (that would not do good things), but I think we still want a warning were it not for the macro, right? Just verifying that this is not changing warning behaviors, only fix-it behaviors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82162/new/

https://reviews.llvm.org/D82162