[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.
Mitch Phillips via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 19 17:56:08 PDT 2020
hctim created this revision.
hctim added reviewers: pcc, ostannard.
Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kristof.beyls, rovka.
Herald added projects: clang, Sanitizers, LLVM.
HWASan globals instruction selection lowering hasn't been implemented in
GlobalISel or FastISel. We need to ensure that we get SelectionDAGISel
in all cases where HWASan is enabled.
GlobalISel is the default ISel for aarch64 at -O0. All others go to
SelectionDAGISel. When we disable GlobalISel, we get FastISel, so
disable that too.
Add a regression test to HWASan, and tighten up the instruction
selection test to also include both PIC and static relocation models.
We intend to add lowering for at least GlobalISel at a later date, but this
is a temporary fix.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D82249
Files:
clang/lib/Driver/SanitizerArgs.cpp
clang/test/Driver/fsanitize.c
compiler-rt/test/hwasan/TestCases/exported-tagged-global.c
llvm/test/CodeGen/AArch64/tagged-globals.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82249.272219.patch
Type: text/x-patch
Size: 5372 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200620/5cdd1091/attachment.bin>
More information about the cfe-commits
mailing list