[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

David Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 19 16:19:30 PDT 2020


davidxl added a comment.

Can you add a test case where there is more than one level of inline contexts for the callsite?



================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:391
+    Remark << ore::NV("Caller", &Caller);
+    if (ProfileGuidedInline)
+      Remark << " by profile guided inliner";
----------------
is this necessary? User should know if their build has profile or not.

What is more useful is when PGO is on, but some callsite does not have profile data, then it is worth reporting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82213/new/

https://reviews.llvm.org/D82213





More information about the cfe-commits mailing list