[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

[Aaron Puchert via Phabricator via cfe-commits]

aaronpuchert added a comment.

Yup, `c-index-test` crashing was one of the motivators behind this.

I think this should handle all cases. I tried it with `CLANG_LINK_CLANG_DYLIB` on/off combined with shared/static/shared+static libraries and inspected the generated `build.ninja`, which looked about right in all cases. (I didn't take the time to run those 6 builds though.)

Since we're just imitating `llvm_add_library` I think it's even theoretically right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67321/new/

https://reviews.llvm.org/D67321