[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 19 09:12:40 PDT 2020


ymandel added a comment.

In D82126#2103772 <https://reviews.llvm.org/D82126#2103772>, @tdl-g wrote:

> LGTM.  I found the change description confusing, since it talks about the selection() stencil but the code is all about the cat() stencil.  I realize (now) that the former is deprecated in favor of the latter.  But the change description is still confusing.


Whoops, I'd forgotten that we'd deprecated that combinator. Thanks for catching that. I've updated the description correspondingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82126/new/

https://reviews.llvm.org/D82126





More information about the cfe-commits mailing list