[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with minor nits.



================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4732
+  case Triple::GOFF:
+    llvm_unreachable("GOFF is not yet implemented");
   case Triple::XCOFF:
----------------
Minor nit: `break` after a function that does not return appears elsewhere in this `switch`; please add a `break` here.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4750
+  case Triple::GOFF:
+    llvm_unreachable("GOFF is not yet implemented");
   case Triple::XCOFF:
----------------
Minor nit: `break` after a function that does not return appears elsewhere in this `switch`; please add a `break` here.


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:908
+  case Triple::GOFF:
+    report_fatal_error("Cannot initialize MC for GOFF object file format");
   case Triple::XCOFF:
----------------
Minor nit: `break` after a function that does not return appears elsewhere in this `switch`; please add a `break` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82081/new/

https://reviews.llvm.org/D82081